Comment 3 for bug 924979

Revision history for this message
Daniel Mustieles (daniel-mustieles) wrote :

Many thanks for implementing it, but I've seen one bug and one possible improve to it.

The bug is, in the same string are several errors, in different tags, only the first error is highlighted. I think it should highlight all the erros found in the same string, not just the first one.

Also, the script bases in character counting/positioning, so tags are partially highlighted. Well, it isn't a ver big problem, since hightlighting errors is a big step, but it would be great if you could highlight the hole mismatched tag.

Just an example to ilustrate both cases:

msgid ""
"Some elements in <app>Accerciser</app> may enable certain functionalities via"
" hotkeys. An example is the <link xref=\"quick_select_plugin\">Quick Select "
"Plugin</link>. The hotkey combination for each functionality can be changed "
"via the Preferences dialog, under the \"Global Hotkeys\" tab. Under this tab,"
" you will find a list of all features for which hotkeys can be configured. "
"Use the <cmd>ctrl</cmd>, <cmd>alt</cmd>, and <cmd>shift</cmd> checkboxes to "
"enable or disable these modifiers."

msgstr ""
"Algunos elementos en <app>Accerciser</aBUG> puede activar ciertas "
"funcionalidades mediante teclas rápidas. Un ejemplo es el <link "
"xref=\"quick_select_plugin\">complemento de selección rápida</link>. La "
"combinación de teclas rápidas para cada funcionalidad se puede cambiar en "
"el diálogo de preferencias, en la pestaña «Teclas rápidas globales». En "
"esta pestaña encontrará una lista de todas las características para las "
"que se pueden configurar las teclas rápidas. Use las casillas "
"<cmd>Ctrl</cmd>, <cmd>Alt</cmd>, y <cmd>Mayús</cBUG> para activar o "
"desactivar estos modificadores."

Note the first and the last one tags, marked with «BUG». The output of gtxml -c pofile.po highlights the substring «r</aBUG» in the first tag, and nothing in the last one. I think it should be highlight the substring «</aBUG>» in both cases.

I've tried to fix it, but I'm not a developer, so I've not been able to help you fixing it :(

BTW, may thanks for you effort attending this bug so quickly :)