Unclear messages while adding a new domain
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Postorius |
Won't Fix
|
Undecided
|
Pavan Koli | ||
Bug Description
If we go to the option of adding a new domain and suppose we keep the Mail Host and Web Host fields blank and try to submit the form. Then a message like 'Please a domain name' is displayed for keeping the Mail Host and Web Host blank. Instead 'Please enter a Mail Host' and 'Please enter a Web Host' should've been displayed.
Also if you enter an invalid Mail Host or an invalid Web Host a message 'Please enter a valid domain name' gets displayed for both of them. I think instead 'Please enter a valid Mail Host' and 'Please enter a valid Web Host' should be displayed.
I think the fields which are required should be marked with an asterix sign. While adding a domain name the mail address and description are optional whereas while creating a new List all the fields are required to be filled, even the description. So putting an asterix in front of required fields will definitely help users understand that the fields are required to be filled.
Related branches
- Terri: Disapprove
-
Diff: 30 lines (+5/-5)1 file modifiedsrc/postorius/forms.py (+5/-5)
| Changed in postorius: | |
| assignee: | nobody → Pavan Koli (pskoli93) |
| status: | New → In Progress |
| Terri (terriko) wrote | #1 |
| Changed in postorius: | |
| status: | In Progress → Won't Fix |
For the purposes of making translation faster, we'd like to re-use strings where reasonable, and I think this is one of those cases, since it should be relatively clear by error placement which field was missing. Plus, Barry tells me these settings are likely to change soonish.