Comment 2 for bug 316730

Revision history for this message
e.mortoray (e-mortoray) wrote :

Note this applies to setting the values int he query object itself, the assumption of correctness is done in the _dbs_dbsource_where function, which directly calls the conversion from Entity to DB.

That is, the values in the entity are correctly converted in where clauses.

However, we can't make the DBS_Query do type conversions since it doesn't know the entity which it is matching. Thus we have to do it in _where, which would also be the most universal.

But, then we just need to call "check" and not actually do the conversion (which is already done)