It would have been great to share a bit of more of details related to the issue. My thinking is that your patch can't work in case of multipath usage since the devices are not registered anymore in sysfs. But it's just one potential issue, it may have others.
As you have noticed, reverting this commit 14be08d0b53836963a530e2990a6db73901cbdac may be a good start but if we can have share details we could also try to fix the change.
If a WWN has been provided in connection_properties, verify that the
found devices have that expected WWN. Fail the attachment if not. This
prevents cases where a device already exists on the host from an old
attachment that wasn't fully cleaned up, and the new attachment got
the same LUN. Using this old device could lead to data corruption.
It would have been great to share a bit of more of details related to the issue. My thinking is that your patch can't work in case of multipath usage since the devices are not registered anymore in sysfs. But it's just one potential issue, it may have others.
As you have noticed, reverting this commit 14be08d0b538369 63a530e2990a6db 73901cbdac may be a good start but if we can have share details we could also try to fix the change.
commit 14be08d0b538369 63a530e2990a6db 73901cbdac
Author: Avishay Traeger <email address hidden>
Date: Tue Jan 29 10:10:50 2019 +0200
Verify WWN of connected iSCSI devices if passed
If a WWN has been provided in connection_ properties, verify that the
found devices have that expected WWN. Fail the attachment if not. This
prevents cases where a device already exists on the host from an old
attachment that wasn't fully cleaned up, and the new attachment got
the same LUN. Using this old device could lead to data corruption.
Change-Id: I45a2221c051821 3dc8132831c0bde 9db4734da2b
Closes-Bug: 1813609
os_brick/ exception. py | 5 +++++ initiator/ connectors/ iscsi.py | 3 +++ initiator/ linuxscsi. py | 10 ++++++++++ tests/initiator /test_linuxscsi .py | 12 ++++++++++++ notes/verify- iscsi-wwns- f6cb536a7fbd4b4 2.yaml | 9 +++++++++
os_brick/
os_brick/
os_brick/
releasenotes/