I've added the power_type argument and split it off from the other changes.
My motivation is twofold:
1- that site.pp should only contain site config and node definitions. The cobbler_node define is similar to every other define we use, and they are all put in either core.pp or cobbler_node.pp. I don't think it's any different.
2- If a customer is deploying to heterogeneous hardware they have to make multiple defines under the current scheme. This can be avoided by adding all the needed parameters to the define.
An alternative is to keep the parameters, but set them to default to a global variable in site.pp. This would make the node definition smaller but add three more global variables, while maintaining the ability to have different power options for each node.
New PR is here: https:/ /github. com/CiscoSystem s/folsom- manifests/ pull/52
I've added the power_type argument and split it off from the other changes.
My motivation is twofold:
1- that site.pp should only contain site config and node definitions. The cobbler_node define is similar to every other define we use, and they are all put in either core.pp or cobbler_node.pp. I don't think it's any different.
2- If a customer is deploying to heterogeneous hardware they have to make multiple defines under the current scheme. This can be avoided by adding all the needed parameters to the define.
An alternative is to keep the parameters, but set them to default to a global variable in site.pp. This would make the node definition smaller but add three more global variables, while maintaining the ability to have different power options for each node.