Comment 29 for bug 579443

Kizza,

Thanks for committing. Some answers/comments below. Where there are no comments I'm in agreement with your decision.

kizza wrote:
> There are a few changes I made before I committed:
> * Changed icon as the one you specified was the wrong colour and the same as the about icon. It's always tough to pick a suitable icon that come with Android, but I think this one's OK.
Thanks! I couldn't find the right one.
> * Changed 'instant' speed to 'current' speed as this is the normal usage in English
> * Removed abbreviation for current and average speed
>
> There are problems with this patch but I committed it anyway so more people can test it. This is what I found:
> * The 'Reset stats' button doesn't seem to work
It does work if there are new updates from GPS. Maybe, I set values to zero immediately.

> * If the GPS isn't updating constantly the average speed goes over 100km/h (I know that this could be hard to solve)
Yes, it's because the network-based location is available first. Then, when GPS reports a location shortly after, it seems as if we traveled very fast from the first to the second location. How about ignoring the network-based location for the purpose of the trip stats?

> * Other languages tend to need more space than English, yet the current layout is already very tight
Agree. For portrait orientation, I could move the values into a new row, each one, just below its description. For landscape orientation we're probably fine as it is now. What do you think?

> * It should always display the units even when there is no data
Agree. I'll do it.

> * The trip time should be in hh:mm:ss format
Definitely. I'll do it.

> * It would be better if the distance is in the format of 'x km y m'. It's more important to have this when using imperial units, as it's hard to convert decimal miles into miles and yards.
Agree again. I'll do it.

> * Should pressing back on the stats screen take you back to the map? At the moment it closes the program. This is technically the right thing to do as the stats page is not a new Activity, but it might confuse users.
I agree, but I have never done this. Is it done somewhere else in OSN?

Thanks for great feedback, Kizza.

There is also another issue, that I'm aware of. Anyone, feel free to take a look at it:
* Switching from portrait to landscape stops the stats updates. Not sure why.

droidguy