Comment 2 for bug 724057
Revision history for this message
| xrg (xrg) wrote Re: [Bug 724057] [NEW] translation needs context but it doesn't always exist | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
On Thursday 24 February 2011, you wrote:
> Public bug reported:
>
> OpenERP v6:
>
> class GettextAlias in tools/translate.py requires a valid context
> available where _() was called. In some cases the context variable does
> not exsits or is not properly initialized. The attached patch provides a
> workarround by searching current user's language in order to find to
> which language it should translate.
>
I have 2 objections to that:
1. Speed. We want to avoid adding overhead to functions. The gettext one must
remain as light as possible (it is sometimes over-used, more than
appropriate).
2. Explicit/Implicit option to translate. In some cases, we explicitly don't
want to have a translation. So far, we have been doing that by not specifying
a 'lang' in the context. 1st example is the loading of a database and
'internal' operations. 2nd example is in server/
*must* avoid translation.
Please think twice before breaking this logic.