Comment 150 for bug 1160365

Revision history for this message
Raphaƫl Valyi - http://www.akretion.com (rvalyi) wrote :

@Folks,

Sorry, my link to decide if a m2o key can be a contact or not and if we should add a contact_id field was wrong, here is it:

https://docs.google.com/document/d/1CvPz-BZnZ-waQZoFpdIM6aNjjcbdLadGQqTZFL3lw7A/edit?usp=sharing
Thank you for helping filling the exhaustive spreadsheet as we have to do it.

@Fabien

You keep answering as if the question was to merge my POC monkeypatch. It's not! it just a POC!
In the cases you are telling, all we need is change the code to replace "partner_id" by "contact_id", so yes, even in a few reports.
In any case, real OpenERP integrations impacted by this bug rarely even use these native OpenERP reports sadly...

Also is a relatively easy change for things that are much less critical than what I describe here if we use only one key mixing companies and persons or swap the partner_id semantic:
https://docs.google.com/presentation/d/1y0njSpm9kqJPGFUQQTiRMIpT1M5CfKppNhslvpl-aM4/pub?start=false&loop=false&delayms=3000#slide=id.p
In these cases, the bugs are critical because the are not about using the company instead of a contact, they use contacts instead of the companies and really fixing them everywhere is very very complex as I explain.

Thanks.