Comment 4 for bug 1151947

Revision history for this message
Raphaƫl Valyi - http://www.akretion.com (rvalyi) wrote :

Hello Guewen,

it's a bit hard to believe we integrators have to spot such basic regression 2.5 months after the official stable "LTS release and 1 year after it has been prototyped... Even more when OpenERP SA itself said they were once interested in e-commerce...

I tend to think is_company should really be used to tell if partner is a company or not. For instance we already assumed that in our localization and assimilated is_company with an equivalent is_company field we had before in the localization.
If is_company suddenly now just means "has several contacts", I think several things will be broken badly for a stable LTS release. And then another flag would be required to tell if partner is a company or not, so it would be totally confusing. So for me, let's keep is_company for companies.

So what I suggest is to go with the solution to add a distinct extra flag to tell if partner has several contacts or not and alter the contacts and parent visibility based on that new flag instead of is_company.
Flag name suggestion: has_hierarchy ? Anything better? I prefer it over is_individual, but may be just a matter of taste.

Also, I personally would prefer to see that fixed inside the core. Yes it's a non trivial change. But on the other side, discovering such a regression at this stage is already so critical that IMHO it justifies an exceptional fixing policy. IMHO this is still better than having all existing modules not depending on that new community module and doing wrong assumptions on their own and the ERP been broken in the wild even if locally fixed, but only in some rare salvation community modules.

Guys, sorry to say it, but such bug makes OpenERP looks really ridiculous. There is no point in blogging about lunch or mail modules, saying sorry to SAP loudly, calleing himself an ERP and getting the partner/address thing wrong. </rant>