Comment 9 for bug 1049653

Hi Damián,

Thanks for reporting the bug with great details and taking the time to submit a patch!

> Sorry Olivier Dony I made a merge proposal but I had an incorrect
> indentation. I delete the previous merge proposal, correct the indentation
> and redid the proposal.

No problem, though in general there is no need to delete and re-create a merge proposal, as they are automatically updated whenever you modify the proposed branch.
I also manually linked your branch with the bug because the link was not created automatically (you probably forgot to tag your commit with `--fixes`. See also [1] )

> I am not sure how to finish the merge and what I have to wait for, so the
> bug is fixed correctly in the nightly build, can you give me some hints?

You don't need to do anything else. Thu did the original implementation, so he will review your patch soon, and he will give you feedback on the merge proposal. He will also assess the risk/benefit ratio of the patch, to see whether it can be applied on the 6.1 stable branch safely [2].

Thanks for your contributions!

[1] For all the gory details regarding merge proposals and how to make them, see the documentation (there's a complete example including --fixes): http://doc.openerp.com/v6.1/contribute/15_guidelines/contribution_guidelines.html

[2] See the OpenERP Bug management policy: http://doc.openerp.com/v6.1/contribute/11_bug_tracker.html#bug-management-policy