Comment 7 for bug 595780

Revision history for this message
Nhomar - Vauxoo (nhomar) wrote : Re: [Bug 595780] Re: [purchase_discount] Wrong implementation in calc or generate packing and invoice

Hello Dukai...

You are right in one thing, i must ask firs before make the push, but IMHO
this is a problema looks like affect only you and me, anybody else has
commented anything :-( . I wait a lot of time before commit my first waiting
arround this problem but nobody improve this.

Like it is a extra-addon module i thought the change can be reviewed for a
lot of people but it wasn't.

BTW, My original problem wasn't only show the price lower, in depth for an
accounting point of view the simply fact of not use the real unit price in
all the process (price with discount included) affect all the behaviour in
at least 4 parts, we have this in our production enviroment and is working
very very well. I try it Your patch! It only resolve the consecuense not
the cause... IMHO the option of use discount _must_ be a standard feature in
the accounting proccess and in the purchase-sale proccess, but like this is
not, we decided make the changes in extra and share it as soon as possible
;-) to take feedback.

For this reason we want give you the solution too! because this is not my
module is our module, and we dedicate a little of time in improve it for you
point of view too!! we think with all opinions involved (in this case your
and my opinion) we can build consistent extra- modules.

I think. Any module in extra-5.0 shouldn't overwritte the standard behaviour
in account (), and the discount management is not the exception, for this
reason i leave the price_unit field for the procces _exactly_ as in the
original is i only overwrite to put some help and change the "label" but, if
at least one more person is disagree with me i can revert all the
change..... without problem.... we can check this with the accounting-expert
list.... are you agree???