Comment 5 for bug 1063251

OK, I got the same error with the fixed branch:
Traceback (most recent call last):
  File "/opt/1/openerp/addons/fetchmail/fetchmail.py", line 221, in fetch_mail
    context=context)
  File "/opt/1/openerp/addons/mail/mail_thread.py", line 361, in message_process
    match = tools.res_re.search(msg.get('subject',_('No Subject')))
TypeError: expected string or buffer

And in the same time - i tried to fix the old stable branch with the same error - I will post the changes i made because i'm not python programmer and i don't know how to submit such fix - BTW the fix is working fine with Arabic (unicode) and (No subject) msgs.

function message_append_dict line 289 :
                            subject = unicode(str(msg_dict.get('subject')),errors='ignore') or "No Subject!",

function message_process line 361:
            match = tools.res_re.search(unicode(str(msg['subject']), errors='ignore'))

that solved the TypeError msg mentioned before and another error of type UnicodeDecodeError ( i don't remember the other Unicode error exactly ).

Again I'm not a python programmer and for sure there's a better way to fix this - or it may not be a bug at all - so plz review and fix the fix if possible.

Hope this helps - and hope it will be fixed in the next release.

Regards,