contrail-controller changes for Windows

Bug #1737177 reported by Pawel Marchewka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Won't Fix
High
Pawel Marchewka
Trunk
In Progress
Undecided
Pawel Marchewka
OpenContrail
Fix Committed
Undecided
Pawel Marchewka

Bug Description

Merge contrail-controller changes for Windows from github.com/codilime/contrail-controller to Juniper/contrail-controller project on review.opencontrail.org

Initial changes:
  https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
  https://github.com/codilime/contrail-controller/commits/windows3.1/src

Changed in opencontrail:
assignee: nobody → Pawel Marchewka (pawelmarchewka)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38302
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38382
Submitter: Pawel Marchewka (<email address hidden>)

2 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38302
Committed: http://github.com/Juniper/contrail-controller/commit/382cccd87dd1565ec09b889cb8934592a3d60f9e
Submitter: Zuul (<email address hidden>)
Branch: master

commit 382cccd87dd1565ec09b889cb8934592a3d60f9e
Author: Michał Cłapiński <email address hidden>
Date: Wed Dec 13 17:58:20 2017 +0100

General changes for Windows

Mixed changes related to net,vnsw/agent/{cfg,controller,diag,filter,pkt}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array otherwise
and on Windows we compile with c++11.
2. addr.to_bytes().c_array() to addr.to_bytes().data()
Difference between boost::array and std::array
3. variable length arrays to dynamic allocation with smart pointers
4. s_addr to s_address, DELETE to DEL, EVENT_MAX to EVENT_MAXIMUM
s_addr, DELETE, EVENT_MAX are reserved on Windows
5. bind to ::bind
To avoid confusion with std::bind
6. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: I7b963703d6d0aefb6591bc40ab6048351bb30593
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38382
Committed: http://github.com/Juniper/contrail-common/commit/442663f4e8d7c15a5f1c884f4332385d066f2c53
Submitter: Zuul (<email address hidden>)
Branch: master

commit 442663f4e8d7c15a5f1c884f4332385d066f2c53
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 12:36:45 2017 +0100

Changes for windows

Changes for windows:
1. Do not build usock_server on windows
2. Use uint8_t instead of u_int8_t
3. Added cast in setsocktopt
4. Changed size_t to std::size_t in some methods (to match to
declaration)

Change-Id: I1336413e541e25ee95c29074f29aa6952e0f5d97
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38461
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38466
Submitter: Michal Clapinski (<email address hidden>)

3 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38342
Committed: http://github.com/Juniper/contrail-controller/commit/05212ee13413504f0384c6d8169cff1749994079
Submitter: Zuul (<email address hidden>)
Branch: master

commit 05212ee13413504f0384c6d8169cff1749994079
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 14 17:04:12 2017 +0100

General changes for Windows

Mixed changes related to schema, xmpp, vnsw/agent/{kstate, vgw, test-xml}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array
otherwise and on Windows we compile with c++11.
2. add linking with advapi32 and gdi32 on Windows
(needed by OpenSSL)
3. do not link with librt on Windows
4. use multiplatform boost::filesystem instead of open/stat/read
5. add missing 'return' to some functions
6. add missing include
7. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: Ifa9a6182300a16c4210d3dc866a333048317b944
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38463
Committed: http://github.com/Juniper/contrail-controller/commit/e83c61b714058b476494dd91a67f2e6745ecc6e7
Submitter: Zuul (<email address hidden>)
Branch: master

commit e83c61b714058b476494dd91a67f2e6745ecc6e7
Author: Michał Cłapiński <email address hidden>
Date: Tue Dec 19 15:53:04 2017 +0100

src/vnsw/agent changes for Windows

1. Created empty class VnswInterfaceListenerWindows
2. Disabled some libs and flags in SConscript for Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent

Change-Id: Ifa57e5a2b3f0e8129dbd647e7e6e378ca8996a86
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38461
Committed: http://github.com/Juniper/contrail-controller/commit/1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Author: Pawel Marchewka <email address hidden>
Date: Tue Dec 19 14:36:11 2017 +0100

Agent services changes for Windows

Agent services changes for Windows:
1. Variable length arrays is only supported in gcc and it is not a part
of C++ standard. We decided to use dynamic allocation and scoped_array.
2. Empty (zero element) array at the end of structure is not portable.
3. Use boost::asio::ip::address_v*::bytes_type, boost from C++0x
uses std::array instead of boost::array

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent/services
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent/services

Change-Id: I938ae8b6b9e1744046c763ecdc40473cc3b56369
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38384
Committed: http://github.com/Juniper/contrail-controller/commit/50c2fdbe648edd244886e8cd88d057f3f82a08dc
Submitter: Zuul (<email address hidden>)
Branch: master

commit 50c2fdbe648edd244886e8cd88d057f3f82a08dc
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 14:48:33 2017 +0100

Don't build nexthop_client and nexthop_server on Windows.

NexthopDBServer uses UnixDomainSocketServer which is not supported on
Windows.

Change-Id: Ibf117424629b66c220c5513da440b73706a0b251
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38485
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38516
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

tags: added: vrouter windows
description: updated
423 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Jacek Izykowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46246
Committed: http://github.com/Juniper/contrail-controller/commit/57826baf2806682010ff949f4cc05513e7b0d8b4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 57826baf2806682010ff949f4cc05513e7b0d8b4
Author: Michal Clapinski <email address hidden>
Date: Mon Sep 17 16:59:34 2018 +0200

Poll for interface MAC address

Sometimes it takes a while for an interface to get the physical
address so it's better to poll.

Change-Id: I6171d63a217de393a41db926a8e0ce0980a7ec48
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45890
Committed: http://github.com/Juniper/contrail-vrouter/commit/43e802164d80162eeb1e3761f6ca68bff38ec019
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 43e802164d80162eeb1e3761f6ca68bff38ec019
Author: Michał Krasnoborski <email address hidden>
Date: Thu Aug 30 17:19:59 2018 +0200

Handle LSO in windows vrouter

Change-Id: I886f6582037ce8c404c546b16d126dffd394504d
Partial-Bug: #1737177
Co-authored-by: Michal Krasnoborski <email address hidden>
Co-authored-by: Mateusz Jablonski <email address hidden>
Co-authored-by: Jacek Izykowski <email address hidden>

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46313
Submitter: Arkadiusz Kudan (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46313
Submitter: Arkadiusz Kudan (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46269
Committed: http://github.com/Juniper/contrail-vrouter/commit/07a81d070d2e501796b65185507a8dff74d3ce82
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 07a81d070d2e501796b65185507a8dff74d3ce82
Author: Mateusz Jablonski <email address hidden>
Date: Tue Sep 18 11:49:42 2018 +0200

Rewrite function with improper license

Change-Id: I7a90bd6892995ee041cc0cb964fe48d02f93dae1
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46313
Submitter: Arkadiusz Kudan (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46275
Committed: http://github.com/Juniper/contrail-controller/commit/535ae429fa4e8c63ad61ddfca222aaf4e3719870
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 535ae429fa4e8c63ad61ddfca222aaf4e3719870
Author: Arkadiusz Kudan <email address hidden>
Date: Mon Sep 17 18:09:04 2018 +0200

Fix vDNS responding on Windows

Sometimes agent didn't respond to VMs' DNS queries
in vDNS mode. It was related to memory with the response being freed,
before Pkt0Interface::WriteHandler have been called.
With this fix, we will ensure that the memory won't be
freed until the handler of async_write function is called.

Change-Id: I07734c22be4134fc22ad1625064d7afb6a3391b7
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46313
Committed: http://github.com/Juniper/contrail-controller/commit/d362b168999011aba674d9ef0608608da6ae9f87
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d362b168999011aba674d9ef0608608da6ae9f87
Author: Arkadiusz Kudan <email address hidden>
Date: Wed Sep 19 14:59:01 2018 +0200

Implement default DNS mode on Windows

In default DNS mode VMs get list of DNS resolvers
from OS on which vRouter agent is running.
Right now, this list is read from /etc/resolv.conf file,
so it doesn't work on Windows.

To get the list of known DNS servers on Windows, we have to use
"iphlpapi" module, which is IP helper API.

This commit will logically divide implementation of building
the list of DNS resolvers in matter of OS the agent is running on.

Change-Id: Iad1b1dcd2237a4f005c8d3207b0ad3e87499326a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46581
Submitter: Przemys?aw Marcinkiewicz (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46583
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46589
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46590
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46591
Submitter: Micha? C?api?ski (<email address hidden>)

1 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46589
Committed: http://github.com/Juniper/contrail-windows/commit/77534f537d847e4ab347fe62b2b8f73ddb39b35b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 77534f537d847e4ab347fe62b2b8f73ddb39b35b
Author: Michał Cłapiński <email address hidden>
Date: Fri Sep 28 18:50:12 2018 +0200

Fix endlines in the whole repository

This repository had Windows-style line endings all over.
This change converts them to Linux-style line endings.

Change-Id: I642e46abd54db3e18299c0ff3515436dabbf43af
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46590
Committed: http://github.com/Juniper/contrail-windows/commit/e47e71b4f2b82d18a545182a040dc4524c392077
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e47e71b4f2b82d18a545182a040dc4524c392077
Author: Michał Cłapiński <email address hidden>
Date: Fri Sep 28 18:54:07 2018 +0200

Return -1 in posix stubs

We were returning 0 in stub functions without setting anything
in the passed structures. Therefore the results were dependent
on random memory. Now we return -1, so nobody should use those
structures.

Change-Id: I7c767d17a98fd8c4c1ce7042194a9c373667f044
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46591
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46617
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46617
Committed: http://github.com/Juniper/contrail-vrouter/commit/5d1e5ab014dbce0e795f5ca31e87ad2fc479df98
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5d1e5ab014dbce0e795f5ca31e87ad2fc479df98
Author: Michal Clapinski <email address hidden>
Date: Mon Oct 1 15:41:14 2018 +0200

Port mirror and vrmemstats utils for Windows

Just enabled building them.

Change-Id: I12dabf6932be3e8dae69f0c17f88c94ccf562828
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46591
Committed: http://github.com/Juniper/contrail-controller/commit/16300d899a2d013465ee18d28594eb0f4e548ffe
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 16300d899a2d013465ee18d28594eb0f4e548ffe
Author: Michal Clapinski <email address hidden>
Date: Fri Sep 28 19:09:39 2018 +0200

Fix default paths on Windows

There are hardcoded paths to /var and /etc in agent.
This PR fixes them for Windows.

Change-Id: If9b152c83fd97765c15fd016c2ec9f26b306417e
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47189
Submitter: Arkadiusz Kudan (<email address hidden>)

5 comments hidden view all 503 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47588
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47189
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47189
Committed: http://github.com/Juniper/contrail-controller/commit/d749fd24c130cd80ca271e2e806c89427d8d9641
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d749fd24c130cd80ca271e2e806c89427d8d9641
Author: Arkadiusz Kudan <email address hidden>
Date: Mon Oct 22 12:47:54 2018 +0200

Delete Agent's Windows service creation

This commit deletes vRouter agent's service creation
from MSI. Right now, we stick to NSSM for Windows service creation
of Contrail components, so MSI creates a "dead" service.

Change-Id: I6309dac661c4f9efb6f8b64d6353664e43ea420b
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39226
Submitter: Micha? C?api?ski (<email address hidden>)

Changed in opencontrail:
status: New → Fix Committed
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Displaying first 40 and last 40 comments. View all 503 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.