The currently proposed fix uses the wrong split count in the following scenario:
1) Split a produce to consume into quantities 50, 70 and 80
2) Produce what would consume 60 (Must be > 50 and < 70)
The resulting consume moves will be
1) Consume 50/50 (as expected)
2) Consume 60/70 (expected 10/70)
This is because the fix doesn't split, when a move to consume has more than the TOTAL amount to consume, then
the total amount to consume is taken instead of what's left to consume. The fixed fix instead compares the remaining
amount to consume and consumes appropriately.
Bug with proposed fix
The currently proposed fix uses the wrong split count in the following scenario:
1) Split a produce to consume into quantities 50, 70 and 80
2) Produce what would consume 60 (Must be > 50 and < 70)
The resulting consume moves will be
1) Consume 50/50 (as expected)
2) Consume 60/70 (expected 10/70)
This is because the fix doesn't split, when a move to consume has more than the TOTAL amount to consume, then
the total amount to consume is taken instead of what's left to consume. The fixed fix instead compares the remaining
amount to consume and consumes appropriately.