Recently in python 3.10.6, a fix has landed in cpython to respond with
a 301 Moved Permanently to a sanitized URL that has had extra leading
'/' characters removed.
This breaks our existing unit tests which assume a 400 Bad Request as
the only expected response.
This adds handling of a 301 Moved Permanently response and asserts that
the redirect location is the expected sanitized URL. Doing this instead
of checking for a given python version will enable the tests to continue
to work if and when the cpython fix gets backported to older python
versions.
While updating the tests, the opportunity was taken to commonize the
code of two unit tests that were nearly identical.
Reviewed: https:/ /review. opendev. org/c/openstack /nova/+ /853379 /opendev. org/openstack/ nova/commit/ 15769b883ed4a86 d62b141ea30d3f1 590565d8e0
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 15769b883ed4a86 d62b141ea30d3f1 590565d8e0
Author: melanie witt <email address hidden>
Date: Tue Aug 16 06:49:53 2022 +0000
Adapt websocketproxy tests for SimpleHTTPServer fix
In response to bug 1927677 we added a workaround to questHandler to respond with a 400 Bad Request if an open
NovaProxyRe
redirect is attempted:
Ie36401c7 82f023d1d5f2623 732619105dc2cfa 24 6330ff09e5eabb5 ef8dd9a18f55478 66
I95f68be7
Recently in python 3.10.6, a fix has landed in cpython to respond with
a 301 Moved Permanently to a sanitized URL that has had extra leading
'/' characters removed.
This breaks our existing unit tests which assume a 400 Bad Request as
the only expected response.
This adds handling of a 301 Moved Permanently response and asserts that
the redirect location is the expected sanitized URL. Doing this instead
of checking for a given python version will enable the tests to continue
to work if and when the cpython fix gets backported to older python
versions.
While updating the tests, the opportunity was taken to commonize the
code of two unit tests that were nearly identical.
Related-Bug: #1927677
Closes-Bug: #1986545
Change-Id: I27441d15cc6fa2 ff7715ba15aa900 961aadbf54a