Comment 30 for bug 1849409

Reviewed: https://review.opendev.org/690746
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b6c7456face630086a0eb7fd1c8335d42ab0456a
Submitter: Zuul
Branch: stable/ocata

commit b6c7456face630086a0eb7fd1c8335d42ab0456a
Author: Matt Riedemann <email address hidden>
Date: Tue Oct 22 17:53:20 2019 -0400

    Add functional regression test for bug 1849409

    Change I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,
    which was backported through to Newton, introduced a regression
    when listing deleted servers with a marker because it assumes
    that if BuildRequestList.get_by_filters does not raise
    MarkerNotFound that the marker was found among the build requests
    and does not account for that get_by_filters method short-circuiting
    if filtering servers with deleted/cleaned/limit=0. The API code
    then nulls out the marker which means you'll continue to get the
    marker instance back in the results even though you shouldn't,
    and that can cause an infinite loop in some client-side tooling like
    nova's CLI:

      nova list --deleted --limit -1

    This adds a functional recreate test for the regression which will
    be updated when the bug is fixed.

    NOTE(mriedem): In this backport the test is modified to disable the
    DiskFilter since we're using Placement for filtering on DISK_GB.
    Also, _wait_until_deleted is moved to InstanceHelperMixin since
    If7b02bcd8d77e94c7fb42b721792c1391bc0e3b7 is not in Ocata.

    Change-Id: I324193129acb6ac739133c7e76920762a8987a84
    Related-Bug: #1849409
    (cherry picked from commit 45c2752f2ce08b314012eff044b01aa7d626b43d)
    (cherry picked from commit 727d942b2830fb6970d99507f2b5eb1a28df01b2)
    (cherry picked from commit 47caaccd4a03660d7df144f2eadd821d36baeaa8)
    (cherry picked from commit 08337cccb060d0b3cad388004c1f802d5d053813)
    (cherry picked from commit f03f5075e3751ccd03a60999eab1d7f4bf7c4f02)
    (cherry picked from commit e2ba87cb7b1cfd4226cfd8028436ecf87ad8a2be)