Comment 22 for bug 1849409

Reviewed: https://review.opendev.org/690720
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=08337cccb060d0b3cad388004c1f802d5d053813
Submitter: Zuul
Branch: stable/rocky

commit 08337cccb060d0b3cad388004c1f802d5d053813
Author: Matt Riedemann <email address hidden>
Date: Tue Oct 22 17:53:20 2019 -0400

    Add functional regression test for bug 1849409

    Change I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,
    which was backported through to Newton, introduced a regression
    when listing deleted servers with a marker because it assumes
    that if BuildRequestList.get_by_filters does not raise
    MarkerNotFound that the marker was found among the build requests
    and does not account for that get_by_filters method short-circuiting
    if filtering servers with deleted/cleaned/limit=0. The API code
    then nulls out the marker which means you'll continue to get the
    marker instance back in the results even though you shouldn't,
    and that can cause an infinite loop in some client-side tooling like
    nova's CLI:

      nova list --deleted --limit -1

    This adds a functional recreate test for the regression which will
    be updated when the bug is fixed.

    NOTE(mriedem): In this backport we get the PlacementFixture from
    the usual nova_fixtures import since change
    Idaed39629095f86d24a54334c699a26c218c6593 is not in Rocky. Also,
    test_concurrent_request_server_group_members_over_quota leaks deleted
    servers from cell0 for some reason in Rocky which can make this test
    intermittently fail. This is not a problem after Rocky for some reason.
    To avoid intermittent failures due to that leak, the test is modified
    to filter on the name of the server created in the test only.

    Change-Id: I324193129acb6ac739133c7e76920762a8987a84
    Related-Bug: #1849409
    (cherry picked from commit 45c2752f2ce08b314012eff044b01aa7d626b43d)
    (cherry picked from commit 727d942b2830fb6970d99507f2b5eb1a28df01b2)
    (cherry picked from commit 47caaccd4a03660d7df144f2eadd821d36baeaa8)