This adds a functional test to recreate a bug where the
instance is deleted after conductor has swapped allocations
to the migration consumer but before casting to compute. In
this case, the scheduler fails due to NoValidHost which is
entirely reasonable. The bug is that the conductor task rollback
code re-creates the allocations on the source node for the
now-deleted instance and as such those allocations get leaked.
Note that we have similar exposures in the live migration
task and reverting allocations when resize fails in the
compute service. A TODO is left inline to add tests for those
separately.
Reviewed: https:/ /review. opendev. org/688980 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=24318f8cd4b 71f1072c6f194a6 f1e04a854acb06
Committed: https:/
Submitter: Zuul
Branch: master
commit 24318f8cd4b71f1 072c6f194a6f1e0 4a854acb06
Author: Matt Riedemann <email address hidden>
Date: Wed Oct 16 13:08:08 2019 -0400
Add functional recreate test for bug 1848343
This adds a functional test to recreate a bug where the
instance is deleted after conductor has swapped allocations
to the migration consumer but before casting to compute. In
this case, the scheduler fails due to NoValidHost which is
entirely reasonable. The bug is that the conductor task rollback
code re-creates the allocations on the source node for the
now-deleted instance and as such those allocations get leaked.
Note that we have similar exposures in the live migration
task and reverting allocations when resize fails in the
compute service. A TODO is left inline to add tests for those
separately.
Change-Id: Ifd156ac8789d3f c84d56d400cf1e1 60e2cd2fbee
Related-Bug: #1848343