Comment 13 for bug 1783565

Reviewed: https://review.opendev.org/696175
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=92eb45ba5eb413400e1789f09d3739ee8c0b77de
Submitter: Zuul
Branch: stable/stein

commit 92eb45ba5eb413400e1789f09d3739ee8c0b77de
Author: melanie witt <email address hidden>
Date: Thu Oct 31 01:57:41 2019 +0000

    Replace time.sleep(10) with service forced_down in tests

    The server group functional tests are doing time.sleep(10) in order
    to make sure a stopped compute service is considered "down" by the nova
    compute API.

    Instead of sleeping, we can set the service as "forced_down" to get the
    desired "down" compute service status and avoid unnecessary delays in
    these tests.

    Unnecessary service start() calls are also removed in this change. They
    appear at the end of tests and services are started during each test
    setUp() and killed during each test tearDown() via the ServiceFixture.

    Closes-Bug: #1783565

    Change-Id: I74f64b68e4b33ee0f8c45fdc5f570c7e12e05d3b
    (cherry picked from commit 1c93ca82b8fb8e39787020decfe335d45f8732e7)
    (cherry picked from commit a5daa0ddb3129ddd1bea4e85570c047fc2912b1a)