libvirt: Always disconnect volumes after libvirtError exceptions
Building on Ib440f4f2e484312af5f393722363846f6c95b760 we should always
attempt to disconnect volumes from the host when exceptions are thrown
while attempting to attach a volume to a domain. This was previously
done for generic exceptions but not for libvirtError exceptions.
Closes-Bug: #1826523
Change-Id: If21230869826c992e7d0398434b9a4b255940213
(cherry picked from commit 091a910576d9b580678f1881fffa425ab4632f48)
(cherry picked from commit 048d5b790f3da2756a0a1bf2bc015812cb24d53a)
(cherry picked from commit 786083c91fa69ba9ff90bafe80d3b83b9f9bbc69)
Reviewed: https:/ /review. opendev. org/657111 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=99a63a6633f 623cc4e6c9b3619 65a9c0935113cf
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 99a63a6633f623c c4e6c9b361965a9 c0935113cf
Author: Lee Yarwood <email address hidden>
Date: Thu Apr 25 15:34:41 2019 +0100
libvirt: Always disconnect volumes after libvirtError exceptions
Building on Ib440f4f2e48431 2af5f3937223638 46f6c95b760 we should always
attempt to disconnect volumes from the host when exceptions are thrown
while attempting to attach a volume to a domain. This was previously
done for generic exceptions but not for libvirtError exceptions.
Closes-Bug: #1826523 92e7d0398434b9a 4b255940213 0678f1881fffa42 5ab4632f48) 56a0a1bf2bc0158 12cb24d53a) 9ff90bafe80d3b8 3b9f9bbc69)
Change-Id: If21230869826c9
(cherry picked from commit 091a910576d9b58
(cherry picked from commit 048d5b790f3da27
(cherry picked from commit 786083c91fa69ba