[SRU] disk over-commit still not correctly calculated during live migration

Fix proposed to branch: master
Review: https://review.openstack.org/536351

Reviewed: https://review.openstack.org/536351
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e2cc275063658b23ed88824100919a6dfccb760d
Submitter: Zuul
Branch: master

commit e2cc275063658b23ed88824100919a6dfccb760d
Author: int32bit <email address hidden>
Date: Mon Jan 22 20:15:21 2018 +0800

    Refix disk size during live migration with disk over-commit

    Currently available disk of targer host is calculated based on
    local_gb, not available disk(free_disk_gb). This check can be
    negative if the target host has no free disk.

    Change-Id: Iec50269ef31dfe090f0cd4db95a37909661bd910
    closes-bug: 1744079

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/602477

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/602478

The attachment "lp1744079_xenial.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

I've uploaded new versions of nova with the fix for this bug to the disco, cosmic, and bionic unapproved queues.

This bug was fixed in the package nova - 2:18.0.1-0ubuntu3

---------------
nova (2:18.0.1-0ubuntu3) disco; urgency=medium

  * d/tests/nova-shebangs-py3: Update shebang for Python 3.7.

 -- Corey Bryant <email address hidden> Wed, 07 Nov 2018 09:11:09 -0500

Hello Matthew, or anyone else affected,

Accepted nova into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova/2:18.0.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Matthew, or anyone else affected,

Accepted nova into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova/2:17.0.6-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Matthew, or anyone else affected,

Accepted nova into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Successfully verified queens-proposed nova 2:17.0.6-0ubuntu2~cloud0

Hi Hua, would you also be able to verify cosmic-proposed and bionic-proposed? Those will need to be verified before queens-proposed can be promoted. Thanks.

This hasn't been tested yet on cosmic-proposed and we have a stable point release of nova to get out so we're going to have to combine this fix with the stable point release. That means this is going to have to live in cosmic-proposed (and rocky-proposed) for another 7 days minimum.

Hello Matthew, or anyone else affected,

Accepted nova into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova/2:18.0.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Matthew, or anyone else affected,

Accepted nova into rocky-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:rocky-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-rocky-needed to verification-rocky-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-rocky-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

This hasn't been tested yet on bionic-proposed and we have a stable point release of nova to get out so we're going to have to combine this fix with the stable point release. That means this is going to have to live in bionic-proposed (and queens-proposed) for another 7 days minimum.

Reviewed: https://review.openstack.org/602477
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1c1c373291a93ad6304ff03ea09fea24a5cb5fd0
Submitter: Zuul
Branch: stable/rocky

commit 1c1c373291a93ad6304ff03ea09fea24a5cb5fd0
Author: int32bit <email address hidden>
Date: Mon Jan 22 20:15:21 2018 +0800

    Refix disk size during live migration with disk over-commit

    Currently available disk of targer host is calculated based on
    local_gb, not available disk(free_disk_gb). This check can be
    negative if the target host has no free disk.

    Change-Id: Iec50269ef31dfe090f0cd4db95a37909661bd910
    closes-bug: 1744079
    (cherry picked from commit e2cc275063658b23ed88824100919a6dfccb760d)

Hello Matthew, or anyone else affected,

Accepted nova into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova/2:17.0.7-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Matthew, or anyone else affected,

Accepted nova into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hi Corey, sorry for the late reply because I am just back from my pto today, I will verify them ASAP.

Successfully verified cosmic-proposed nova 2:18.0.3-0ubuntu1

Successfully verified bionic-proposed nova 2:17.0.7-0ubuntu1

Successfully verified queens-proposed nova 2:17.0.7-0ubuntu1~cloud0

Successfully verified rocky-proposed nova 2:18.0.3-0ubuntu1~cloud0

Hi Corey, could you pls nominate this fix to xenial as well? we have a customer using xenial-mitaka, I have uploaded a debdiff 'lp1744079_xenial.debdiff', many thanks.

Reviewed: https://review.openstack.org/602478
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b2c7483003789ecaa0eea8afb49b783934bbf0f
Submitter: Zuul
Branch: stable/queens

commit 1b2c7483003789ecaa0eea8afb49b783934bbf0f
Author: int32bit <email address hidden>
Date: Mon Jan 22 20:15:21 2018 +0800

    Refix disk size during live migration with disk over-commit

    Currently available disk of targer host is calculated based on
    local_gb, not available disk(free_disk_gb). This check can be
    negative if the target host has no free disk.

    Change-Id: Iec50269ef31dfe090f0cd4db95a37909661bd910
    closes-bug: 1744079
    (cherry picked from commit e2cc275063658b23ed88824100919a6dfccb760d)

@Hua, we'll have to fix this in pike and ocata before it can be fixed in mitaka.

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 2:18.0.3-0ubuntu1

---------------
nova (2:18.0.3-0ubuntu1) cosmic; urgency=medium

  * d/gbp.conf: Create stable/rocky branch.
  * d/p/disk-size-live-migration-overcommit.patch: Cherry-picked from
    https://review.openstack.org/#/c/602477 to ensure proper disk calculation
    during live migration with over-commit (LP: #1744079).
  * New stable point release for OpenStack Rocky (LP: #1806049).

 -- Corey Bryant <email address hidden> Mon, 03 Dec 2018 12:23:48 -0500

This bug was fixed in the package nova - 2:17.0.7-0ubuntu1

---------------
nova (2:17.0.7-0ubuntu1) bionic; urgency=medium

  * d/p/disk-size-live-migration-overcommit.patch: Cherry-picked from
    https://review.openstack.org/#/c/602478 to ensure proper disk calculation
    during live migration with over-commit (LP: #1744079).
  * New stable point release for OpenStack Queens (LP: #1806043).

 -- Corey Bryant <email address hidden> Fri, 07 Dec 2018 08:27:02 -0500

This issue was fixed in the openstack/nova 18.1.0 release.

This issue was fixed in the openstack/nova 17.0.9 release.

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 2:17.0.7-0ubuntu1~cloud0
---------------

 nova (2:17.0.7-0ubuntu1~cloud0) xenial-queens; urgency=medium
 .
   * New upstream release for the Ubuntu Cloud Archive.
 .
 nova (2:17.0.7-0ubuntu1) bionic; urgency=medium
 .
   * d/p/disk-size-live-migration-overcommit.patch: Cherry-picked from
     https://review.openstack.org/#/c/602478 to ensure proper disk calculation
     during live migration with over-commit (LP: #1744079).
   * New stable point release for OpenStack Queens (LP: #1806043).

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 2:18.0.3-0ubuntu1~cloud0
---------------

 nova (2:18.0.3-0ubuntu1~cloud0) bionic-rocky; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 nova (2:18.0.3-0ubuntu1) cosmic; urgency=medium
 .
   * d/gbp.conf: Create stable/rocky branch.
   * d/p/disk-size-live-migration-overcommit.patch: Cherry-picked from
     https://review.openstack.org/#/c/602477 to ensure proper disk calculation
     during live migration with over-commit (LP: #1744079).
   * New stable point release for OpenStack Rocky (LP: #1806049).

Hua, have you attempted to get the pike and ocata patches backported upstream? If possible we need to get them upstream first for affected releases.

Change abandoned by Zhang Hua (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/631372

For stable/pike
https://review.openstack.org/#/c/530743
https://review.openstack.org/#/c/631372

For stable/ocata
https://review.openstack.org/#/c/530744
https://review.openstack.org/#/c/631376

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

Reviewed: https://review.openstack.org/631372
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e485938f5e7b2f7f9c69f97b6c1b58b3de8d68ec
Submitter: Zuul
Branch: stable/pike

commit e485938f5e7b2f7f9c69f97b6c1b58b3de8d68ec
Author: int32bit <email address hidden>
Date: Mon Jan 22 20:15:21 2018 +0800

    Refix disk size during live migration with disk over-commit

    Currently available disk of targer host is calculated based on
    local_gb, not available disk(free_disk_gb). This check can be
    negative if the target host has no free disk.

    Change-Id: Iec50269ef31dfe090f0cd4db95a37909661bd910
    closes-bug: 1744079
    (cherry picked from commit e2cc275063658b23ed88824100919a6dfccb760d)
    Signed-off-by: Zhang Hua <email address hidden>

Hello Matthew, or anyone else affected,

Accepted nova into pike-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:pike-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-pike-needed to verification-pike-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-pike-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Matthew, or anyone else affected,

Accepted nova into ocata-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ocata-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ocata-needed to verification-ocata-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ocata-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

A new version of nova has been uploaded to the xenial unapproved queue where it is awaiting SRU team review: https://launchpad.net/ubuntu/xenial/+queue?queue_state=1&queue_text=nova

Successfully verified pike-proposed nova 2:16.1.7-0ubuntu1~cloud2 and ocata-proposed nova 2:15.1.5-0ubuntu1~cloud3

Reviewed: https://review.openstack.org/631376
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0b0030ea2273840bd428070b2f23e755a30d2a35
Submitter: Zuul
Branch: stable/ocata

commit 0b0030ea2273840bd428070b2f23e755a30d2a35
Author: int32bit <email address hidden>
Date: Mon Jan 22 20:15:21 2018 +0800

    Refix disk size during live migration with disk over-commit

    Currently available disk of targer host is calculated based on
    local_gb, not available disk(free_disk_gb). This check can be
    negative if the target host has no free disk.

    Change-Id: Iec50269ef31dfe090f0cd4db95a37909661bd910
    closes-bug: 1744079
    (cherry picked from commit e2cc275063658b23ed88824100919a6dfccb760d)
    Signed-off-by: Zhang Hua <email address hidden>

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 2:15.1.5-0ubuntu1~cloud3
---------------

 nova (2:15.1.5-0ubuntu1~cloud3) xenial-ocata; urgency=medium
 .
   * d/p/(re)fix-disk-size-during-live-migration-with-disk-over-commit.patch:
     Cherry-picked from upstream ocata gerrit reviews to ensure disk size check
     is corectly calculated on the destination host for live migration with
     disk over-commit (LP: #1708572) (LP: #1744079).

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 2:16.1.7-0ubuntu1~cloud2
---------------

 nova (2:16.1.7-0ubuntu1~cloud2) xenial-pike; urgency=medium
 .
   * d/p/(re)fix-disk-size-during-live-migration-with-disk-over-commit.patch:
     Cherry-picked from upstream stable/pike branch to ensure disk size check
     is corectly calculated on the destination host for live migration with
     disk over-commit (LP: #1708572) (LP: #1744079).

This issue was fixed in the openstack/nova 16.1.8 release.

Hello Matthew, or anyone else affected,

Accepted nova into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova/2:13.1.4-0ubuntu4.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Matthew, or anyone else affected,

Accepted nova into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Successfully verified xenial-proposed nova 2:13.1.4-0ubuntu4.4

Successfully verified mitaka-proposed nova 2:13.1.4-0ubuntu4.4~cloud0

This bug was fixed in the package nova - 2:13.1.4-0ubuntu4.4

---------------
nova (2:13.1.4-0ubuntu4.4) xenial; urgency=medium

  * Refix disk size during live migration with disk over-commit
    - (LP: #1708572) and (LP: #1744079)
    - d/p/0001-Fix-disk-size-during-live-migration-with-disk-over-c.patch
    - d/p/0002-Refix-disk-size-during-live-migration-with-disk-over.patch

 -- Zhang Hua <email address hidden> Tue, 02 Apr 2019 18:48:16 +0800

The verification of the Stable Release Update for nova has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nova - 2:13.1.4-0ubuntu4.4~cloud0
---------------

 nova (2:13.1.4-0ubuntu4.4~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 nova (2:13.1.4-0ubuntu4.4) xenial; urgency=medium
 .
   * Refix disk size during live migration with disk over-commit
     - (LP: #1708572) and (LP: #1744079)
     - d/p/0001-Fix-disk-size-during-live-migration-with-disk-over-c.patch
     - d/p/0002-Refix-disk-size-during-live-migration-with-disk-over.patch

This issue was fixed in the openstack/nova ocata-eol release.