Comment 32 for bug 1784579

Reviewed: https://review.openstack.org/626556
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e61b1d7d72470a95068470d67779e08ececdb2e5
Submitter: Zuul
Branch: stable/ocata

commit e61b1d7d72470a95068470d67779e08ececdb2e5
Author: Stephen Finucane <email address hidden>
Date: Wed Dec 19 16:03:22 2018 +0000

    Handle unbound vif plug errors on compute restart

    As with change Ia963a093a1b26d90b4de2e8fc623031cf175aece, we can
    sometimes cache failed port binding information which we'll see on
    startup. Long term, the fix for both issues is to figure out how this is
    being cached and stop that happening but for now we simply need to allow
    the service to start up.

    To this end, we copy the approach in the aforementioned change and
    implement a translation function in os_vif_util for unbound which
    will make the plug_vifs code raise VirtualInterfacePlugException which
    is what the _init_instance code in ComputeManager is already handling.

    This has the same caveats as that change, namely that there may be
    smarter ways to do this that we should explore. However, that change
    also included a note which goes someway to explaining this.

    Conflicts:
     nova/compute/manager.py
     nova/tests/unit/network/test_os_vif_util.py

    NOTE(sfinucan): As with the 'stable/ocata' backport of change
    Ia963a093a1b26d90b4de2e8fc623031cf175aece, the compute manager conflicts
    are due to change I2740ea14e0c4ecee0d91c7f3e401b2c29498d097 in Queens.
    The _LE() marker has to be left intact for pep8 checks in Ocata. The
    test_os_vif_util conflicts are due to not having change
    Ic23effc05c901575f608f2b4c5ccd2b1fb3c2d5a nor change
    I3f38954bc5cf7b1690182dc8af45078eea275aa4 in Ocata

    Change-Id: Iaec1f6fd12dba8b11991b7a7595593d5c8b1db50
    Signed-off-by: Stephen Finucane <email address hidden>
    Related-bug: #1784579
    Closes-bug: #1809136
    (cherry picked from commit 1def76a1c49032d93ab6c7ee61dbbfe8e29cafca)
    (cherry picked from commit bc0a5d0355311641daa87b46e311ae101f1817ad)
    (cherry picked from commit 79a90d37027b7ca131218e16eaee70d6d5152206)
    (cherry picked from commit 7b4f5725f821ef89176ef69f036471eaaf8a6201)