OpenStack Compute (nova)

  1. Series queens
  2. Bug #1752152
  3. Comment #18

Comment 18 for bug 1752152

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/557508
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=20eaaee2334957eb8739ecca524a1c4aa9f246e9
Submitter: Zuul
Branch: master

commit 20eaaee2334957eb8739ecca524a1c4aa9f246e9
Author: Eric Fried <email address hidden>
Date: Wed Mar 28 15:45:26 2018 -0500

    Use ksa session for cinder microversion check

    [1] added a method to validate availability of a desired version of the
    cinder API. This method called into
    cinderclient.client.get_highest_client_server_version to
    (unsurprisingly) discover the highest available version to compare
    against. However, that routine uses a raw requests.get to access the
    version document from the server. This breaks when the endpoint URL is
    using HTTPS, because nothing sets up the cert info for that call.

    With this change, we work around the issue by duplicating the logic from
    get_highest_client_server_version, but doing the version discovery via
    the same keystoneauth1 session that's configured for use with the client
    itself, thus inheriting any SSL configuration as appropriate.

    [1] https://review.openstack.org/#/c/469579/

    Change-Id: I4de355195281009a5979710d7f14ae8ea11d10e0
    Closes-Bug: #1752152