Comment 9 for bug 1721843

Reviewed: https://review.openstack.org/510957
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=38dbb0595072092f13c4017dc4edf811fa70fa21
Submitter: Zuul
Branch: stable/pike

commit 38dbb0595072092f13c4017dc4edf811fa70fa21
Author: Balazs Gibizer <email address hidden>
Date: Mon Oct 9 16:29:09 2017 +0200

    Fix sending legacy instance.update notification

    The if_notifications_enabled decorator skips the execution of the
    decorated function if the versioned notifications are not configured
    to be emitted. The send_instance_update_notification() call was wrongly
    decorated with this decorator as it not only sends versioned
    notification but also send the legacy compute.instance.update
    notification as well. This caused that the legacy instance.update
    notification was not emitted when the notification_format config option
    was set to unversioned.

    As the _send_versioned_instance_update() call already has the decorator
    the solution is simply to remove the decorator from the
    send_instance_update_notification() call.

    Closes-Bug: #1721843
    Change-Id: I9904adeb3de60cff4e29f1ab3c95399bbe9ff2e7
    (cherry picked from commit 0ffe03a2650a698de1b83289098ed535734b2360)