commit 5d5c5a5d92458d530115b3d3b8b381524b1a3a90
Author: Matt Riedemann <email address hidden>
Date: Mon Oct 16 16:23:28 2017 -0400
libvirt: add check for VIR_DOMAIN_BLOCK_REBASE_COPY_DEV
Change I868a0dae0baf8cded9c7c5807ea63ffc5eec0c5e adds some
code that relies on the VIR_DOMAIN_BLOCK_REBASE_COPY_DEV flag
which was introduced to libvirt in commit
b7e73585a8d96677695a52bafb156f26cbd48fb5 which went into the
1.2.9 release:
The nova change went into the Pike release and was backported
to stable/ocata, and went into the 15.0.6 release. However,
in ocata the minimum required version of libvirt is 1.2.1, so
it's possible people could be running libvirt in ocata with
libvirt < 1.2.9 which would then result in an AttributeError
if doing a swap volume operation on a block type device.
This adds a check to see if the attribute exists before attempting
to use it.
Note that this change is not made on the master branch since starting
in Pike the minimum required version of libvirt is 1.2.9.
Reviewed: https:/ /review. openstack. org/512406 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=5d5c5a5d924 58d530115b3d3b8 b381524b1a3a90
Committed: https:/
Submitter: Zuul
Branch: stable/ocata
commit 5d5c5a5d92458d5 30115b3d3b8b381 524b1a3a90
Author: Matt Riedemann <email address hidden>
Date: Mon Oct 16 16:23:28 2017 -0400
libvirt: add check for VIR_DOMAIN_ BLOCK_REBASE_ COPY_DEV
Change I868a0dae0baf8c ded9c7c5807ea63 ffc5eec0c5e adds some BLOCK_REBASE_ COPY_DEV flag 96677695a52bafb 156f26cbd48fb5 which went into the
code that relies on the VIR_DOMAIN_
which was introduced to libvirt in commit
b7e73585a8d
1.2.9 release:
https:/ /libvirt. org/git/ ?p=libvirt. git;a=blob; f=docs/ news-2014. html.in
The nova change went into the Pike release and was backported
to stable/ocata, and went into the 15.0.6 release. However,
in ocata the minimum required version of libvirt is 1.2.1, so
it's possible people could be running libvirt in ocata with
libvirt < 1.2.9 which would then result in an AttributeError
if doing a swap volume operation on a block type device.
This adds a check to see if the attribute exists before attempting
to use it.
Note that this change is not made on the master branch since starting
in Pike the minimum required version of libvirt is 1.2.9.
Change-Id: Ie3789bda6c6417 249e279739b80a6 1c5b525421f
Closes-Bug: #1724039