Comment 2 for bug 1685185

Reviewed: https://review.openstack.org/458807
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=809065485c19fd535db6740bb21b867c41c008fe
Submitter: Jenkins
Branch: master

commit 809065485c19fd535db6740bb21b867c41c008fe
Author: Lee Yarwood <email address hidden>
Date: Thu Apr 20 19:43:32 2017 +0100

    libvirt: Always disconnect_volume after rebase failures

    Previously failures when rebasing onto a new volume would leave the
    volume connected to the compute host. For some volume backends such as
    iSCSI the subsequent call to terminate_connection would then result in
    leftover devices remaining on the host.

    This change simply catches any error associated with the rebase and
    ensures that disconnect_volume is called for the new volume prior to
    terminate_connection finally being called.

    Change-Id: I5997000a0ba6341c4987405cdc0760c3b471bd59
    Closes-bug: #1685185