Comment 3 for bug 1581246

Reviewed: https://review.openstack.org/316336
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d2875b78b5746bfcb082a7c5385375d704518581
Submitter: Jenkins
Branch: master

commit d2875b78b5746bfcb082a7c5385375d704518581
Author: Matt Riedemann <email address hidden>
Date: Fri May 13 22:28:24 2016 -0400

    ironic: fix call to _cleanup_deploy on config drive failure

    The call to _cleanup_deploy when config drive generation failed
    during spawn didn't match the method signature. This was missed
    in unit testing because the assertion on the mock of that method
    matched the actual call, but not the actual method signature.

    This fixes the call and also fixes the test by auto-spec'ing the
    _cleanup_deploy method in the mock so that it validates the actual
    function signature is called correctly.

    In order to use autospec properly here, the mock has to be on the
    driver object rather than the class.

    Change-Id: Ic2c096ef846f11f94aa828222c927ed7d03051c9
    Closes-Bug: #1581246