Comment 57 for bug 1251590

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/68658
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b0d36683fe064b32cbef013e1c0c46bd018ab9a1
Submitter: Jenkins
Branch: master

commit b0d36683fe064b32cbef013e1c0c46bd018ab9a1
Author: Nikola Dipanov <email address hidden>
Date: Tue Dec 10 17:43:17 2013 +0100

    libvirt: Fix root disk leak in live mig

    This patch makes sure that i_create_images_and_backing method of the
    libvirt driver (called in several places, but most problematic one is
    the call in the pre_live_migration method) creates all the files the
    instance needs that are not present.

    Prioir to this patch - the method would only attempt to download the
    image, and if it did so with the path of the ephemeral drives, it could
    expose the image to other users as an ephemeral devices. See the related
    bug for more detaiis.

    After this patch - we properly distinguish between image, ephemeral and
    swap files, and make sure that the imagebackend does the correct thing.

    Closes-bug: #1251590

    Co-authored-by: Loganathan Parthipan <email address hidden>

    Change-Id: I78aa2f4243899db4f4941e77014a7e18e27fc63e