Also, for context, the details and history of why noVNC changed is that previously, in the vnc_lite.html file used to handle a 'token' query parameter and stash it in a cookie, which we would process on the nova console proxy side:
But after that noVNC commit (v1.1.0) they stopped handling the 'token' query parameter and passing it in a cookie. So they directed us to use the 'path' query parameter instead:
Also, for context, the details and history of why noVNC changed is that previously, in the vnc_lite.html file used to handle a 'token' query parameter and stash it in a cookie, which we would process on the nova console proxy side:
https:/ /github. com/novnc/ noVNC/commit/ 51f9f0098d306bb c67cc8e02ae5479 21b6f6585c# diff-1d6838e381 2778e95699b90d5 30543a1L173
https:/ /github. com/openstack/ nova/blob/ 207d2c22538ddec 4d82fafbc01e756 c9d25f6e36/ nova/console/ websocketproxy. py#L168
But after that noVNC commit (v1.1.0) they stopped handling the 'token' query parameter and passing it in a cookie. So they directed us to use the 'path' query parameter instead:
https:/ /github. com/novnc/ noVNC/pull/ 1220
It's clear now that this is something specific to noVNC but somehow I confused it because noVNC and websockify are/used to be so closely connected.
I think the right thing to do is leave the noVNC specific handling to get_vnc_console only.