commit abaa86fd86d4beca0082ff1768d5306e5e86302e
Author: Matt Riedemann <email address hidden>
Date: Tue Jun 5 19:57:49 2018 +0000
Revert "Fix listing of instances above API max_limit"
This reverts commit eff607ccef91d09052d58f6798f68d67404f51ce.
There was no apparent need for the change being reverted since
user can list all servers by specifying --limit=1 when running
the nova list command.
The change introduced a problem whereby the first pass to
list instances from the server would get up to
[api]/max_limit (default 1000) results and then call again
with a marker. If the last instance in the list (the marker)
is corrupted in the instance_mappings table in the API DB
by not having an associated cell mapping, listing instances
will always fail with a MarkerNotFound error even though
the CLI user is not passing a marker nor specifying
--limit=-1. The corrupted instance mapping record resulting
in the MarkerNotFound error is something else that should
be fixed on the server side (and likely result in a 500) but
the change in behavior of the CLI makes it always fail
if you hit this even if you're not passing a marker.
Reviewed: https:/ /review. openstack. org/572539 /git.openstack. org/cgit/ openstack/ python- novaclient/ commit/ ?id=abaa86fd86d 4beca0082ff1768 d5306e5e86302e
Committed: https:/
Submitter: Zuul
Branch: master
commit abaa86fd86d4bec a0082ff1768d530 6e5e86302e
Author: Matt Riedemann <email address hidden>
Date: Tue Jun 5 19:57:49 2018 +0000
Revert "Fix listing of instances above API max_limit"
This reverts commit eff607ccef91d09 052d58f6798f68d 67404f51ce.
There was no apparent need for the change being reverted since
user can list all servers by specifying --limit=1 when running
the nova list command.
The change introduced a problem whereby the first pass to
list instances from the server would get up to
[api]/max_limit (default 1000) results and then call again
with a marker. If the last instance in the list (the marker)
is corrupted in the instance_mappings table in the API DB
by not having an associated cell mapping, listing instances
will always fail with a MarkerNotFound error even though
the CLI user is not passing a marker nor specifying
--limit=-1. The corrupted instance mapping record resulting
in the MarkerNotFound error is something else that should
be fixed on the server side (and likely result in a 500) but
the change in behavior of the CLI makes it always fail
if you hit this even if you're not passing a marker.
Change-Id: Ibb43f500a74733 b85bd3242592d36 985bfb45856
Closes-Bug: #1773945