Remove dest node allocation if evacuate MoveClaim fails
If the MoveClaim during an evacuate fails we need to
remove the destination node allocation since the
ResourceTracker isn't going to do it.
This also fixes test_rebuild_server_exc which was faking
a rebuild failure by raising an error that would not
actually happen during a rebuild. ComputeResourcesUnavailable
only happens if a claim fails, and for a rebuild, which
is on the same host that the instance is already on, doesn't
involve a claim attempt.
Reviewed: https:/ /review. openstack. org/499878 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=5bc137f7ebc 266f8a73d6febc7 c10d8d648924e0
Committed: https:/
Submitter: Jenkins
Branch: master
commit 5bc137f7ebc266f 8a73d6febc7c10d 8d648924e0
Author: Matt Riedemann <email address hidden>
Date: Fri Sep 1 09:58:03 2017 -0400
Remove dest node allocation if evacuate MoveClaim fails
If the MoveClaim during an evacuate fails we need to
remove the destination node allocation since the
ResourceTracker isn't going to do it.
This also fixes test_rebuild_ server_ exc which was faking sUnavailable
a rebuild failure by raising an error that would not
actually happen during a rebuild. ComputeResource
only happens if a claim fails, and for a rebuild, which
is on the same host that the instance is already on, doesn't
involve a claim attempt.
Change-Id: I59ff47bf773c98 31d0f44e1caf787 7fe08c911c3
Closes-Bug: #1713786