Comment 16 for bug 1607714

Reviewed: https://review.openstack.org/431778
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1ecd71b08d14450e475dc9512d40828da6fcfe15
Submitter: Jenkins
Branch: master

commit 1ecd71b08d14450e475dc9512d40828da6fcfe15
Author: Matt Riedemann <email address hidden>
Date: Thu Feb 9 18:41:11 2017 -0500

    libvirt: fix and break up _test_attach_detach_interface

    The detach_interface flow in this test was broken because
    it wasn't mocking out domain.detachDeviceFlags so the xml
    it was expecting to be passed to that method wasn't actually
    being verified. The same thing is broken in test
    test_detach_interface_device_with_same_mac_address because
    it copies the other broken test code.

    This change breaks apart the monster attach/detach test method
    and converts the detach_interface portion to mock and fixes
    the broken assertion.

    test_detach_interface_device_with_same_mac_address is just
    fixed, not converted to mock.

    Change-Id: I6d9a975876c5652ef544c587f65b1bdd1543848b
    Related-Bug: #1607714