commit e7840303a683d91b01a8c73328f93419c41d7815
Author: Chris Yeoh <email address hidden>
Date: Thu Aug 7 14:08:13 2014 +0930
Make API name validation failure deterministic
Makes the testing of a valid name in the API deterministic
with respect to failing when an empty name is supplied
by the user. Formerly it could fail either of two constraints
- must be at least one character long
- does not match the valid regexp which requires one character
The lack of deterministic behaviour was causing issues with
some unittests when PYTHONHASHSEED is not set to 0 because
of the two failure modes. The second constraint for validation
of names is now modified so it allows empty strings but overall the
behaviour remains the same because of the first constraint.
Reviewed: https:/ /review. openstack. org/112470 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=e7840303a68 3d91b01a8c73328 f93419c41d7815
Committed: https:/
Submitter: Jenkins
Branch: master
commit e7840303a683d91 b01a8c73328f934 19c41d7815
Author: Chris Yeoh <email address hidden>
Date: Thu Aug 7 14:08:13 2014 +0930
Make API name validation failure deterministic
Makes the testing of a valid name in the API deterministic
with respect to failing when an empty name is supplied
by the user. Formerly it could fail either of two constraints
- must be at least one character long
- does not match the valid regexp which requires one character
The lack of deterministic behaviour was causing issues with
some unittests when PYTHONHASHSEED is not set to 0 because
of the two failure modes. The second constraint for validation
of names is now modified so it allows empty strings but overall the
behaviour remains the same because of the first constraint.
Change-Id: Iea89bb329a8939 af5168926717b5c 13bdf2a7f62
Partial-Bug: 1350287