Comment 24 for bug 1257644

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/60584
Committed: http://github.com/openstack/nova/commit/4b6df96adec23ba90fd6277d88d7edd6c514fe73
Submitter: Jenkins
Branch: master

commit 4b6df96adec23ba90fd6277d88d7edd6c514fe73
Author: Matt Riedemann <email address hidden>
Date: Fri Dec 6 10:39:34 2013 -0800

    libvirt: add a test to guard against set_host_enabled raising an error

    Commit cc70e3a adds a finally block to _get_new_connection to
    automatically disable the host if making a connection to libvirt fails.

    The set_host_enabled method currently swallows all exceptions which is
    good so it doesn't mask the original libvirt failure in
    _get_new_connection, but we need to have a test that makes sure that
    isn't unintentionally regressed. This patch adds the test.

    Related-Bug: #1257644

    Change-Id: I4beec053794edc75ef2d0060a05285f7ed0b99ac