child_department in category->scopes doesn't work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
News Scope |
Fix Committed
|
High
|
Penk Chen | ||
scope-aggregator |
Fix Released
|
Critical
|
Zhang Enwei |
Bug Description
From scope aggregator 4.8 release, child_department in category->scopes doesn't work.
How to reproduce:
Install news-china and sinanews, check all the departments, sinanews returns same items.
Root Cause,
utils.cpp-
if (agg_scope_
{
child_dept = child_dept.
scopeLocalI
}
should be
if (agg_scope_
{
if (child_
{
child_dept = child_dept.
}
scopeLocalI
}
Related branches
- Kyle Nitzsche (community): Approve
- Gary.Wang: Approve
- Penk Chen: Pending requested
-
Diff: 38 lines (+11/-5)2 files modifiedCMakeLists.txt (+1/-1)
src/utils.cpp (+10/-4)
Changed in scope-aggregator: | |
assignee: | nobody → Zhang Enwei (zhangew401) |
importance: | Undecided → Critical |
status: | New → In Progress |
Changed in scope-aggregator: | |
status: | In Progress → Fix Committed |
Changed in news-scope: | |
assignee: | nobody → Kyle Nitzsche (knitzsche) |
importance: | Undecided → High |
status: | New → Confirmed |
marking this released in scope-aggregator since I just merged google test impl and released 4.12.