Remove dhcp_extra_opt value after first newline character
Passing newline to the dnsmasq may cause security issues, especially
that in case of Neutron that dhcp options' values are controlled by
cloud users.
This patch removes everything what is after first newline character
in the dhcp_extra_opt's values before passing them to dnsmasq.
Reviewed: https:/ /review. opendev. org/c/openstack /neutron/ +/806709 /opendev. org/openstack/ neutron/ commit/ 110fed07cb83deb 3abd85073cb3510 66713b6384
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/queens
commit 110fed07cb83deb 3abd85073cb3510 66713b6384
Author: Slawek Kaplonski <email address hidden>
Date: Mon Aug 23 13:01:37 2021 +0200
Remove dhcp_extra_opt value after first newline character
Passing newline to the dnsmasq may cause security issues, especially
that in case of Neutron that dhcp options' values are controlled by
cloud users.
This patch removes everything what is after first newline character
in the dhcp_extra_opt's values before passing them to dnsmasq.
Conflicts:
neutron/ tests/unit/ agent/linux/ test_dhcp. py
Closes-Bug: #1939733 6f25620ac4116d6 18980a7272e 01f27d7c0376d97 02e178ecfb)
Change-Id: Ifeaf258f0b5ea8
(cherry picked from commit df891f0593d234e