args pass to securitygroup precommit event should include the complete info

Fix proposed to branch: master
Review: https://review.openstack.org/281693

Related fix proposed to branch: master
Review: https://review.openstack.org/393676

Reviewed: https://review.openstack.org/390783
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=2066b64affef5a7576202c80b3cafa51aa5df7a8
Submitter: Jenkins
Branch: master

commit 2066b64affef5a7576202c80b3cafa51aa5df7a8
Author: Isaku Yamahata <email address hidden>
Date: Wed Oct 26 11:00:32 2016 +0200

    secgroup: pushdown default secgroup rules to ODL

    When security group is created, corresponding default security group
    rules are also created. But there is no corresponding callbacks. So
    when security group is created, the special logic to create security
    group rules need to be pushed down to ODL.
    The modification to v2 driver is a sort of bug work around until the
    patch [1] is needed for v2 driver.

    [1] https://review.openstack.org/#/c/281693/

    Change-Id: I7305d6c970f352bde0111a9a9fe6612bae1ebd5f
    Related-bug: #1546910

Related fix proposed to branch: master
Review: https://review.openstack.org/393989

Reviewed: https://review.openstack.org/393989
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=eb53b789393c3603309c907e0f6a7e1900212bbd
Submitter: Jenkins
Branch: master

commit eb53b789393c3603309c907e0f6a7e1900212bbd
Author: Isaku Yamahata <email address hidden>
Date: Fri Nov 4 23:40:34 2016 -0700

    mech v2: bug/1546910 work around

    precommit_create of security group rule doesn't pass its id of security
    group rule. As bug work around, pick it from sqlalchemy session.new.
    limitation: bulk creation isn't supported so that exception is raised.

    Change-Id: Ie742df496cb1528892b84d635f7ce0bbcf6e1b24
    Related-Bug: #1546910

Reviewed: https://review.openstack.org/393676
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=9194396e07649fd0353ceb31d25d5717b0767afe
Submitter: Jenkins
Branch: master

commit 9194396e07649fd0353ceb31d25d5717b0767afe
Author: Isaku Yamahata <email address hidden>
Date: Tue Oct 25 18:44:59 2016 +0200

    devstack: enable force config drive

    Since metadata isn't supported depending on setting, enable
    force config drive so that vm instance can get metadata via config
    drive.

    Change-Id: I757a975987b9f2ec88322d66ac2d9359d563b340
    Related-bug: #1546910
    Co-Authored-By: Marcus Williams <email address hidden>

Related fix proposed to branch: master
Review: https://review.openstack.org/404003

Reviewed: https://review.openstack.org/404003
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=194da19e84ddabaa2237bd8f971ac331298e3620
Submitter: Jenkins
Branch: master

commit 194da19e84ddabaa2237bd8f971ac331298e3620
Author: Isaku Yamahata <email address hidden>
Date: Mon Nov 28 18:41:39 2016 -0800

    mech driver v2: build dict for sg on update

    precommit callback for security group precommit doesn't pass
    complete information. So build it in callback as bug work around.
    precoomit callback should be passed full information.
    Once it's fixed, this bug work around should be removed.
    The original bug report[1] is filed for ODL, but it turned out
    the issue resides in neutron and networking-odl

    [1] https://bugs.opendaylight.org/show_bug.cgi?id=7256

    Change-Id: I15b6f5321cd3e860de7ba50dd5dde8672259c9ba
    Related-bug: #1546910

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/417682

Reviewed: https://review.openstack.org/417682
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=ff0d05ac6b8d8165f8f29747e0ca2b29c252e66e
Submitter: Jenkins
Branch: stable/newton

commit ff0d05ac6b8d8165f8f29747e0ca2b29c252e66e
Author: Isaku Yamahata <email address hidden>
Date: Mon Nov 28 18:41:39 2016 -0800

    mech driver v2: build dict for sg on update

    precommit callback for security group precommit doesn't pass
    complete information. So build it in callback as bug work around.
    precoomit callback should be passed full information.
    Once it's fixed, this bug work around should be removed.
    The original bug report[1] is filed for ODL, but it turned out
    the issue resides in neutron and networking-odl

    [1] https://bugs.opendaylight.org/show_bug.cgi?id=7256

    Change-Id: I15b6f5321cd3e860de7ba50dd5dde8672259c9ba
    Related-bug: #1546910
    (cherry picked from commit 194da19e84ddabaa2237bd8f971ac331298e3620)

Same issue is also being observed in Mitaka. Can this be back-ported to stable/mitaka?

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/281693
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Fix proposed to branch: master
Review: https://review.openstack.org/448420

Reviewed: https://review.openstack.org/448420
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=89abce3efe0645cc08e840b4cc4d455889ee8866
Submitter: Jenkins
Branch: master

commit 89abce3efe0645cc08e840b4cc4d455889ee8866
Author: Reedip <email address hidden>
Date: Wed Mar 22 07:24:33 2017 +0000

    Pass the complete info in sg/rules db into PRECOMMIT_XXX callback

    PRECOMMIT_XXX events callback need completed sg info, like the sg id
    and its related rules for registered driver.

    Change-Id: I6f49f25eb2ad16221357024f45a6bb6175d5cd55
    Co-Authored-By: Rui Wang <email address hidden>
    Co-Authored-By: Manjeet Singh Bhatia <email address hidden>
    Co-Authored-By: Yalei Wang <email address hidden>
    Closes-bug: #1546910

Reviewed: https://review.openstack.org/475649
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=154b8750bcdc7053e29c790e5106c4750d05e110
Submitter: Jenkins
Branch: master

commit 154b8750bcdc7053e29c790e5106c4750d05e110
Author: Isaku Yamahata <email address hidden>
Date: Mon Jun 19 12:31:00 2017 -0700

    security group: pass update value to precommit_update

    This patch is follow up for [1].
    When updating security group, pass updated value to precommit.
    old value is passed as original_security_group and new value
    is passed as security_group.
    [1] https://review.openstack.org/#/c/448420/

    Although argument to callbacks will be unified by EventPayload
    eventually, it's necessary to unbreak decomposed modules.

    Change-Id: I5a27d1d218a0be4fae6f9740559bbbf773518821
    Related-bug: #1546910

Related fix proposed to branch: master
Review: https://review.openstack.org/476389

Reviewed: https://review.openstack.org/476389
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=256ffafc591e03bd0605628c134042135a514fb7
Submitter: Jenkins
Branch: master

commit 256ffafc591e03bd0605628c134042135a514fb7
Author: Isaku Yamahata <email address hidden>
Date: Wed Jun 21 21:46:01 2017 -0700

    enable test_security_group_update

    The test was disabled for bug.
    Enable it again.

    Change-Id: Ieec0cefb4812caf69e362dda48b91aa60cebad17
    Depends-On: I5a27d1d218a0be4fae6f9740559bbbf773518821
    Related-bug: #1546910

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.