v2 - on security group update, need to pass all the security group details - failing security group update in netvirt CSIT

Bug #1652807 reported by Alon Kochba
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-odl
New
High
Unassigned

Bug Description

When a security-group attribute is updated, in this case the SG name, networking-odl_v1 used to pass the entire structure.
In v2, it seems the update is sent with only the new data, without any uuid etc. - this causes a neutron northbound failure and this test case in netvirt CSIT fails [1], when trying to verify the update in MDSAL.

The previous behavior in v1 can be viewed here [2], original q-svc log [3].

In v2, the following data is sent [4], original q-svc [5], and karaf log [6] outputs these errors:
2016-12-27 02:48:34,031 | WARN | qtp863596267-903 | NeutronSecurityGroupInterface | 244 - org.opendaylight.neutron.transcriber - 0.7.3.SNAPSHOT | Attempting to write neutron securityGroup without UUID
2016-12-27 02:48:34,032 | ERROR | qtp863596267-903 | ContainerResponse | 70 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
java.lang.IllegalArgumentException: All keys must be specified for class org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.secgroups.rev150712.security.groups.attributes.security.groups.SecurityGroupKey. Missing key is getUuid. Supplied key is SecurityGroupKey []
 at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
 at org.opendaylight.yangtools.binding.data.codec.impl.ValueContext.getAndSerialize(ValueContext.java:43)
 at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.serialize(IdentifiableItemCodec.java:122)

[1] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-upstream-learn-boron/46/archives/log.html.gz#s1-s1-s1-t1-k15
[2] http://paste.openstack.org/show/593478/
[3] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-upstream-learn-boron/49/archives/control/q-svc.log.2016-12-26-154413.gz
[4] http://paste.openstack.org/show/593480/
[5] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-upstream-learn-boron/46/archives/control/q-svc.log.2016-12-27-021300.gz
[6] https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-newton-nodl-v2-upstream-learn-boron/46/archives/odl1_karaf.log.gz

Changed in networking-odl:
importance: Undecided → High
Mike Kolesnik (mkolesni)
Changed in networking-odl:
status: New → Fix Committed
status: Fix Committed → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.