© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
* I like the decision to apply replaygain being decided by BaseTrackPlayer
* I like adding an analyser progress meter back into WOverview (so you can see progress even if the overview waveform is pre-calculated)
* I like the change to EnginePregain to immediately apply the initial replaygain.
* The total-gain calculation could be pre-calculated but that's probably a very minor performance optimization.
* I think whether replaygain should take effect even if a track is playing should be a ReplayGain preference defaulted to off.
My main objection to the patch is still the artificial delay of the progress. It seems to me this adds a lot of complexity for only a little bit of a benefit.