Comment 11 for bug 840860

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 840860] Re: reload track metadata changes gain of a playing track

On Thu, Sep 6, 2012 at 5:04 PM, Daniel Schürmann
<email address hidden>wrote:

> Hi RJ,
>
> thank you for reviewing this.
>
> For me the main issue is solved without having a progress visualisation
> for the finalise part of the analysis queue,
> because of the Replay gain is not adopted when playing.
> So if you like, I will prepare a patch which only visualise the process
> function part.
>

Sounds good -- let's go with that for now.

>
> Although I am still in favour for a solution which visualise the whole
> analysis time until finished. It is a more general solutions for all
> upcoming analyser tasks which have a long finalise function like replay
> gain analysis has today.
>

In practice I'm seeing ReplayGain's finalize step taking less than 1ms on
average. How long are you seeing it take?

>
> I do not see a valid use case for replay gain adoption on a playing
> deck. So I think we need not implement a preference option, until we
> have one.
>

OK we can hold off on that.

Thanks a lot,
RJ

> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/840860
>
> Title:
> reload track metadata changes gain of a playing track
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/840860/+subscriptions
>