Mixxx

Bug #599267
Comment #7

Comment 7 for bug 599267

Revision history for this message

Albert Santoni (gamegod) wrote on 2011-01-02: Re: [Bug 599267] Re: M4A files don't show up in library with plugin

#7

On Sat, Jan 1, 2011 at 8:19 PM, Bill Good <email address hidden> wrote:
> I had the plugin working the other day on win32 (7) without issue. The
> biggest thing (well now that it actually seems to build again), as
> detailed in this bug, is the plugin either has to be in a path mixxx
> look for it in (see src/soundsourceproxy.cpp for those paths) or has to
> be in a path given to mixxx at runtime with --pluginPath
> dir/to/{dll|dylib|so}.
>
> I'm not well read on the library or its scanner, it may be that if the
> scanner hits a file it doesn't know, it disregards it in future scans,
> which would explain why m4a's don't get imported but are there in
> browse, assuming you've got the plugin loaded one way or another.
> lp:mixxx/1.9 does have a list of all the plugins it's got loaded in the
> preferences as of a few revs ago, otherwise building with the debug
> console enabled does loads to determining if the plugin is being found
> and properly loaded (not that this is possible with the current build
> system afaict but *sigh*).

The library scanner doesn't remember disregarded files, but it does
remember a hash of the list of files in each directory. Since the list
of files hasn't changed, the hash is the same and so the library
scanner is probably just skipping over every directory because it
doesn't think there's any new files in there.

We should make the library scanner maybe use the supported file
extensions regex when it gets the directory listing. The QFileIterator
created on line 347 in LibraryScanner is where you'd make this change.
(Also see SoundSourceProxy::supportedFileExtensionsRegex(), which is a
static function.)

Thanks,
Albert

>
> Regardless, I'm not too worried about the bug as the plugin is only
> slightly better than dead-in-the-water for all intents and purposes.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/599267
>
> Title:
> M4A files don't show up in library with plugin
>

On Sat, Jan 1, 2011 at 8:19 PM, Bill Good <599267@bugs.launchpad.net> wrote:
> I had the plugin working the other day on win32 (7) without issue. The
> biggest thing (well now that it actually seems to build again), as
> detailed in this bug, is the plugin either has to be in a path mixxx
> look for it in (see src/soundsourceproxy.cpp for those paths) or has to
> be in a path given to mixxx at runtime with --pluginPath
> dir/to/{dll|dylib|so}.
>
> I'm not well read on the library or its scanner, it may be that if the
> scanner hits a file it doesn't know, it disregards it in future scans,
> which would explain why m4a's don't get imported but are there in
> browse, assuming you've got the plugin loaded one way or another.
> lp:mixxx/1.9 does have a list of all the plugins it's got loaded in the
> preferences as of a few revs ago, otherwise building with the debug
> console enabled does loads to determining if the plugin is being found
> and properly loaded (not that this is possible with the current build
> system afaict but *sigh*).

The library scanner doesn't remember disregarded files, but it does
remember a hash of the list of files in each directory. Since the list
of files hasn't changed, the hash is the same and so the library
scanner is probably just skipping over every directory because it
doesn't think there's any new files in there.

We should make the library scanner maybe use the supported file
extensions regex when it gets the directory listing. The QFileIterator
created on line 347 in LibraryScanner is where you'd make this change.
(Also see SoundSourceProxy::supportedFileExtensionsRegex(), which is a
static function.)

Thanks,
Albert

>
> Regardless, I'm not too worried about the bug as the plugin is only
> slightly better than dead-in-the-water for all intents and purposes.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/599267
>
> Title:
>  M4A files don't show up in library with plugin
>