Mixxx

updating cue point seeks to old cue point

Bug #1946415 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Committed
Medium
Owen Williams
Mixxx 2.4.0

Bug Description

on main, if I try to set a new cue point, the operation works, but the track seeks to where the cue point used to be

Revision history for this message
Nino MP (ninomp) wrote (last edit ):

I noticed this too, but I think this only happens when trying to place cue point in preroll.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Nino MP (ninomp)
Revision history for this message
Owen Williams (ywwg) wrote :

This happens to me 100% of the time, not just preroll

Revision history for this message
Owen Williams (ywwg) wrote :

Ah, it's because of 036754d081a, which did this:

- double cuePoint = m_pCuePoint->get();
+ const auto mainCuePosition =
+ mixxx::audio::FramePos::fromEngineSamplePosMaybeInvalid(
+ m_pCuePoint->get());

so when the cuepoint is updated, we seek to the old position.

Revision history for this message
Owen Williams (ywwg) wrote :

I'm making a small PR, should be uncontroversial?

Changed in mixxx:
assignee: Nino MP (ninomp) → Owen Williams (ywwg)
Revision history for this message
Owen Williams (ywwg) wrote :

https://github.com/mixxxdj/mixxx/pull/4370

Revision history for this message
Jan Holthuis (holthuis-jan) wrote :

@ywwg: I don't understand how the bug was caused by the change diff you posted. The lines are identical semantically, it's just that the variable type is different.

Revision history for this message
Owen Williams (ywwg) wrote :

it's not caused by just those lines -- by assigning the cue position to a variable, when we update the cue position the variable still has the old value. See the PR for the complete fix.

Be (be.ing)
Changed in mixxx:
status: Confirmed → Fix Committed
milestone: none → 2.4.0
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10551

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.