>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1362
>> + GST_TRACE("Reconfiguring file download template from '%s' to '%s'", oldDownloadTemplate.get(), newDownloadTemplate.get());
>
> Nit: you can move getting oldDownloadTemplate after setting newDownloadTemplate (it is going to be actually used before the GST_TRACE and specially relevant for the purge).
>
> Another nit: "Reconfigured" is better because the relevant action already happened.
Comment on attachment 300398
Patch
View in context: https:/ /bugs.webkit. org/attachment. cgi?id= 300398& action= review
>> Source/ WebCore/ platform/ graphics/ gstreamer/ MediaPlayerPriv ateGStreamer. cpp:1362 "Reconfiguring file download template from '%s' to '%s'", oldDownloadTemp late.get( ), newDownloadTemp late.get( ));
>> + GST_TRACE(
>
> Nit: you can move getting oldDownloadTemplate after setting newDownloadTemplate (it is going to be actually used before the GST_TRACE and specially relevant for the purge).
>
> Another nit: "Reconfigured" is better because the relevant action already happened.
Forget this, it is wrong.