percona-server/5.1$ bzr log -r 0.15786.4
------------------------------------------------------------
revno: 0.15786.4
committer: Venkata Sidagam <email address hidden>
branch nick: mysql-5.1-13955256
timestamp: Thu 2012-07-19 13:52:34 +0530
message: Bug #12615411 - server side help doesn't work as first statement
Problem description:
Giving "help 'contents'" in the mysql client as a first statement
gives error
Analysis:
In com_server_help() function the "server_cmd" variable was
initialised with buffer->ptr(). And the "server_cmd" variable is not
updated since we are passing "'contents'"(with single quote) so the
buffer->ptr() consists of the previous buffer values and it was sent
to the mysql_real_query() hence we are getting error.
Fix:
We are not initialising the "server_cmd" variable and we are updating
the variable with "server_cmd= cmd_buf" in any of the case i.e with
single quote or without single quote for the contents.
As part of error message improvement, added new error message in case
of "help 'contents'".
Oracle fixed it in 5.1.66 and 5.5.28. Closing.
percona-server/5.1$ bzr log -r 0.15786.4 ------- ------- ------- ------- ------- ------- ------- ----
-------
revno: 0.15786.4
committer: Venkata Sidagam <email address hidden>
branch nick: mysql-5.1-13955256
timestamp: Thu 2012-07-19 13:52:34 +0530
message:
Bug #12615411 - server side help doesn't work as first statement
Problem description:
Giving "help 'contents'" in the mysql client as a first statement
gives error
Analysis:
In com_server_help() function the "server_cmd" variable was
initialised with buffer->ptr(). And the "server_cmd" variable is not
updated since we are passing "'contents'"(with single quote) so the
buffer->ptr() consists of the previous buffer values and it was sent
to the mysql_real_query() hence we are getting error.
Fix:
We are not initialising the "server_cmd" variable and we are updating
the variable with "server_cmd= cmd_buf" in any of the case i.e with
single quote or without single quote for the contents.
As part of error message improvement, added new error message in case
of "help 'contents'".