Yasufumi> XtraDB already has the following code.
Yasufumi> if (flag & HA_STATUS_TIME) {
Yasufumi> - if (innobase_stats_on_metadata) {
Yasufumi> + if (innobase_stats_on_metadata
Yasufumi> + || thd_sql_command(user_thd) == SQLCOM_ANALYZE
Yasufumi> + ) {
Yasufumi> /* In sql_show we call with this flag: update
Yasufumi> then statistics so that they are up-to-date */
Yasufumi> Why was the bug confirmed??
I don't think you should depend on the SQLCOM_ANALYZE status; Someone
may want in the future to call analyze() from other points in the code.
A better way would be to add an engine specific
HA_STATUS_INNODB_ANALYZE flag from ha_innobase::analyze() and test
this in info().
Hi!
>>>>> "Yasufumi" == Yasufumi Kinoshita <email address hidden> writes:
Yasufumi> XtraDB already has the following code. stats_on_ metadata) { stats_on_ metadata command( user_thd) == SQLCOM_ANALYZE
Yasufumi> if (flag & HA_STATUS_TIME) {
Yasufumi> - if (innobase_
Yasufumi> + if (innobase_
Yasufumi> + || thd_sql_
Yasufumi> + ) {
Yasufumi> /* In sql_show we call with this flag: update
Yasufumi> then statistics so that they are up-to-date */
Yasufumi> Why was the bug confirmed??
I don't think you should depend on the SQLCOM_ANALYZE status; Someone
may want in the future to call analyze() from other points in the code.
A better way would be to add an engine specific INNODB_ ANALYZE flag from ha_innobase: :analyze( ) and test
HA_STATUS_
this in info().
Regards,
Monty