Share has new keys for share capabilities that affect APIs: snapshot_support, create_share_from_snapshot_support, replication_type, mount_snapshot_support, revert_to_snapshot_support.
Only replication_type is present in the share instance object sent down to the driver, even if we assume that the share instance has all of the share data set in it.
More info on this bug (19/03/2020)
There are things we know that are in the share model that can help drivers when acting on any share but, we don't pass them down... drivers are already written in a way to call back into the database and retrieve the share type. So, if we make this change, in theory drivers can avoid that call - however, driver authors may still not have everything they need.
Adding this params would avoid an unnecessary round trip to the database from within a share driver.
Hey Goutham any update on this one ?