Comment 16 for bug 265930

Originator: NO

Thank you very much, Mark!

I'm assuming that this is the commit you're talking about:

http://marc.info/?l=mailman-cvs&m=119440136928253&w=2

I just applied the following diff to a debian lenny installation (mailman
2.1.9-8) i've been experimenting on:

--- Scrubber.py.orig 2007-11-06 21:15:30.000000000 -0500
+++ Scrubber.py 2007-11-06 21:16:07.000000000 -0500
@@ -342,7 +342,8 @@
         text = []
         for part in msg.walk():
             # TK: bug-id 1099138 and multipart
- if not part or part.is_multipart():
+ # MAS test payload - if part may fail if there are no
headers.
+ if not part._payload or part.is_multipart():
                 continue
             # All parts should be scrubbed to text/plain by now.
             partctype = part.get_content_type()

After recompiling Scrubber.py, I then did:

 /var/lib/mailman/bin/arch --wipe testlist

and it fixed a message with a similar formatting issue that had previously
been blank.

My only concern is that in the thread you linked to, it's mentioned that
arch --wipe can break external links. This makes me reluctant to use it to
fix older archives with blank messages which might have accumulated
external links. URLs should be stable! Is this really a possible
consequence of arch --wipe?