Comment 7 for bug 1882272

I was testing the solution adopted in lm-sensors 3.6.0-6 and later, and there is something that is bothering me a bit.

To recap, the fix that was applied is to restart the fancontrol service in the systemd-sleep hook. That sounds find, but imagine this scenario. I installed fancontrol, it's configured and running. For some reason, I decided to disable it, but keep the package installed. I do this then:

sudo systemctl disable fancontrol.service

In this way, the service will only start if a manual start command is issued, like "sudo systemctl start fancontrol.service". It won't start on boot, for example.

Except if you have the systemd-sleep hook in place.

You boot the machine, fancontrol is not running. Then you suspend it, and when it's resumed, fancontrol will be (re)started and will be running. I think that would be surprising behavior, because I disabled the service.

You can then mask the service, so that not even "sudo systemctl start fancontrol.service" will start it, but I still find that a bit unexpected, from a user's point of view. Maybe it's best to write a better hook, one that will only issue the restart if the service is enabled.