Comment 8 for bug 882824

Revision history for this message
SegundoBob (bhossley) wrote : Re: [Bug 882824] Re: bookmarks_show command with free_layout plugin not enabled sends AttributeError to console

On 03/15/2012 03:51 PM, Edward K. Ream wrote:
> On Thu, Mar 15, 2012 at 1:31 PM, SegundoBob <email address hidden> wrote:
> ...
>> > File "/home/bob/bzr/LeoLatest/leo/plugins/bookmarks.py", line 77, in
>> > bookmarks_show
>> > splitter = bmd.c.free_layout.get_top_splitter()
>> > AttributeError: 'Commands' object has no attribute 'free_layout'
> Fixed for good, I think, at rev 5147. The bookmarks plugin now forces
> the load of the free_layout plugin in the 'after-create-leo-frame'
> event handler. This allows the rest of the code to assume that both
> c.free_layout and c.free_layout.get_top_splitter exist.
>
> EKR

I confirm that now there are no error messages sent to the console or to
the log pane. You have probably done all you can.

But I think Terry North needs to make some changes to make it do what he
wants and what is reasonable in corner cases.

When the currently selected node is not in an @bookmarks subtree,
bookmarks_show seems to do nothing. When the currently selected node
was in an @bookmarks subtree, I got the "bookmarks" sub-window in the
body pane, not the Log pane. See the attached snapshot

Test System:
Ubuntu 11.10 with Fluxbox window manager
Leo Log Window
Leo 4.9.1 devel, build 5147, 2012-03-15 16:08:20
Python 2.7.2, qt version 4.7.3
linux2
setting leoID from os.getenv('USER'): 'bob'
load dir: /home/bob/bzr/LeoLatest/leo/core
global config dir: /home/bob/bzr/LeoLatest/leo/config
home dir: /home/bob
reading settings in /home/bob/bzr/LeoLatest/leo/config/leoSettings.leo
reading settings in /home/bob/.leo/myLeoSettings.leo
reading settings in /home/bob/.leo/workbook.leo
reading: /home/bob/.leo/workbook.leo

--
Segundo Bob
<email address hidden>