+archivesubscriptions shows links to merged users.

Bug #684112 reported by Gavin Panella
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

On https://launchpad.net/~allenap/+archivesubscriptions it says I have a subscription to the Kalliki internal PPA (ppa:kalliki-merged/internal). The owner link to the Kalliki Developers is broken: https://launchpad.net/~kalliki-merged

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 684112] [NEW] Link to PPA owner from +archivesubscriptions is broken

I guess this is because someone merged an account with a PPA, is that the case
Gavin?

Revision history for this message
Gavin Panella (allenap) wrote : Re: Link to PPA owner from +archivesubscriptions is broken

It looks like it from the team name, but I've never heard of Kalliki before so I don't know what the history is.

Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
Julian Edwards (julian-edwards) wrote :

The template is rendered with

                <td><tal:owner content="structure subscription/archive/owner/fmt:link">

so this could be a registry bug?

Also, there's an existing registry bug 676966 about not allowing accounts to be merged if they have a PPA.

Gavin, I can't get into your subscriptions page, can you post a screen shot please?

Revision history for this message
Gavin Panella (allenap) wrote :

Sure. I don't know how private/sensitive the other PPAs in the list are so I've pixelated them to be on the safe side.

Revision history for this message
Gavin Panella (allenap) wrote :

> The template is rendered with
>
> <td><tal:owner content="structure
> subscription/archive/owner/fmt:link">
>
> so this could be a registry bug?

Quite possibly. I nearly filed this bug on Registry at first.

The fix might be as simple as not rendering links to disabled teams
and/or users, just displaying the icon and name.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks Gavin. Curtis, shouldn't the person links be rendered strikeout and no linkage if they're disabled?

affects: soyuz → launchpad-registry
Revision history for this message
Curtis Hovey (sinzui) wrote :

this is actually a merge defect. Once the merge has happened the user should cease to exist. The user's PPA subscription was not merged, so that insane link is renderable.

Changed in launchpad-registry:
status: New → Triaged
importance: Undecided → Low
tags: added: 404 tales trivial
Changed in launchpad-registry:
milestone: none → series-future
tags: added: merge-deactivate
summary: - Link to PPA owner from +archivesubscriptions is broken
+ Link to PPA merged owner from +archivesubscriptions is broken
Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 684112] Re: Link to PPA owner from +archivesubscriptions is broken

Fixing the other bug to stop merging accounts with PPAs will implicitly fix
this then.

Revision history for this message
Curtis Hovey (sinzui) wrote : Re: Link to PPA merged owner from +archivesubscriptions is broken

This might be the script to run one Edwin's merge fix is released:
-- Deactivate all archives that belong to merged users.
-- Set archive ito DELETING and disable it.
-- This assumes all jobs are complete.
update archive
set
    status = 1,
    enabled = FALSE
from
    person p
where
    p.id = a.owner
    and p.merged is not null
    and a.status = 0;
;

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 684112] Re: Link to PPA merged owner from +archivesubscriptions is broken

On Thursday 16 December 2010 05:47:24 you wrote:
> This might be the script to run one Edwin's merge fix is released:
> -- Deactivate all archives that belong to merged users.
> -- Set archive ito DELETING and disable it.
> -- This assumes all jobs are complete.
> update archive
> set
> status = 1,
> enabled = FALSE
> from
> person p
> where
> p.id = a.owner
> and p.merged is not null
> and a.status = 0;
> ;

Almost - we need to also delete and expire all its publications.

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: Link to PPA merged owner from +archivesubscriptions is broken

<sinzui> EdwinGrubbs, bigjools I think my suggest is bad. I suspect that the clean up proc will never remove the directories because the user/team names have changed
<bigjools> sinzui: indeed, I had overlooked that
<bigjools> it needs a manual cleanup to get the orphaned PPA repos
<sinzui> bigjools, the list is small. could re prepare a shell script to remove them?
<bigjools> should be fairly trivial, we just get a list of all repos and check that they are valid in LP

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Anyone who previously merged accounts with PPAs will have a corrupted PPA; there's not much we can do about that though. (corrupt as in the data in the account will not matched what's published under its new ID)

Curtis Hovey (sinzui)
summary: - Link to PPA merged owner from +archivesubscriptions is broken
+ +archivesubscriptions shows links to merged users.
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.